Enable experimental R/W support by default downstream on APFS DRV

2024-10-23 12:24:51 +03:00
parent 1ed9f0ddcf
commit a9cd8d8d47
2 changed files with 65 additions and 0 deletions
@@ -0,0 +1,55 @@
+From e9dfb693ab15084c38805631a90730bc8c22dd37 Mon Sep 17 00:00:00 2001
+From: Bahar Kurt <kurtbahartr@users.noreply.github.com>
+Date: Tue, 22 Oct 2024 10:07:18 +0300
+Subject: [PATCH] Enable the experimental write support by default
+
+It looks safe enough for daily usage.
+---
+ super.c | 14 ++++++++++----
+ 1 file changed, 10 insertions(+), 4 deletions(-)
+
+diff --git a/super.c b/super.c
+index 5fc2b2b..a07be9a 100644
+--- a/super.c
+++ b/super.c
+@@ -1184,6 +1184,9 @@ static int parse_options(struct super_block *sb, char *options)
+ 	/* Set default values before parsing */
+ 	nx_flags = 0;
+ 
+	/* DOWNSTREAM: Set r/w to be the default. It looks safe and sane enough to me. - Bedirhan */
+	nx_flags |= APFS_READWRITE;
+
+ 	if (!options)
+ 		goto out;
+ 
+@@ -1196,10 +1199,13 @@ static int parse_options(struct super_block *sb, char *options)
+ 		switch (token) {
+ 		case Opt_readwrite:
+ 			/*
+-			 * Write support is not safe yet, so keep it disabled
+-			 * unless the user requests it explicitly.
+			 * Write support is not safe yet, and it was disabled upstream,
+			 * but it looks safe and usable enough for data recovery and
+			 * little operations like fixing corrupted files.
+ 			 */
+-			nx_flags |= APFS_READWRITE;
+			//nx_flags |= APFS_READWRITE;
+			apfs_warn(sb, "no need to explicitly state r/w mounts");
+			apfs_notice(sb, "we have already made it the default for you downstream");
+ 			break;
+ 		case Opt_cknodes:
+ 			/*
+@@ -1242,9 +1248,9 @@ out:
+ 	if (!(sb->s_flags & SB_RDONLY)) {
+ 		if (nxi->nx_flags & APFS_READWRITE) {
+ 			apfs_notice(sb, "experimental write support is enabled");
+			apfs_notice(sb, "this is default only downstream, and you should blame the packager for loss of written data, not the upstream");
+ 		} else {
+ 			apfs_warn(sb, "experimental writes disabled to avoid data loss");
+-			apfs_warn(sb, "if you really want them, check the README");
+ 			sb->s_flags |= SB_RDONLY;
+ 		}
+ 	}
+-- 
+2.46.2
+