From 451bb5901074f147967c7c1e72f809ba63a4b811 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eray=20=C3=96zkural?= Date: Sun, 14 Aug 2005 17:38:05 +0000 Subject: [PATCH] * comments --- pisi/specfile.py | 2 ++ pisi/toplevel.py | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pisi/specfile.py b/pisi/specfile.py index 92f20ad9..e39a2269 100644 --- a/pisi/specfile.py +++ b/pisi/specfile.py @@ -409,6 +409,8 @@ class SpecFile(XmlFile): def has_errors(self): """Return errors of the PSPEC file if there are any.""" + #TODO: has_errors name is misleading for a function that does + #not just return a boolean value. check() would be better - exa err = Checks() err.join(self.source.has_errors()) if len(self.packages) <= 0: diff --git a/pisi/toplevel.py b/pisi/toplevel.py index d1f82319..379f4b2d 100644 --- a/pisi/toplevel.py +++ b/pisi/toplevel.py @@ -103,8 +103,6 @@ def install_pkg_files(package_URIs): extra_packages = [x.package for x in dep_unsatis] if (extra_packages and install_pkg_names(extra_packages)) or \ (not extra_packages): - #FIXME: Construct a dependency graph for files - # and install in rev. topological order class PackageDB: def __init__(self):