* fix: log to /var/log/ only if we have permission to write (not like syslog)

pisi/api.py

@@ -67,11 +67,15 @@ def init(database = True, write = True,
     else:
         ctx.ui = ui
 
+    
+    if os.access('/var/log', os.W_OK):
+        ctx.log = True
         logging.basicConfig(level=logging.DEBUG,
             format='%(asctime)s %(levelname)-8s %(message)s',
             datefmt='%a, %d %b %Y %H:%M:%S',
-                    filename='/var/log/pisi.log',
+            filename='/var/log/pisi.log')
-                    filemode='w')
+    else:
+        ctx.log = False
 
     # If given define stdout and stderr. Needed by buildfarm currently
     # but others can benefit from this too.
@@ -110,6 +114,7 @@ def init(database = True, write = True,
 def finalize():
     if ctx.initialized:
     
+        if ctx.log:
             logging.shutdown()
     
         pisi.repodb.finalize()

pisi/cli/__init__.py

@@ -75,6 +75,7 @@ class CLI(UI):
 
     def warning(self, msg, verbose = False):
         msg = unicode(msg)
+        if ctx.log:
             logging.warning(msg)
         if ctx.get_option('no_color'):
             self.output(_('Warning: ') + msg + '\n', err=True, verbose=verbose)
@@ -83,6 +84,7 @@ class CLI(UI):
 
     def error(self, msg):
         msg = unicode(msg)
+        if ctx.log:
             logging.error(msg)
         if ctx.get_option('no_color'):
             self.output(_('Error: ') + msg + '\n', err=True)
@@ -92,6 +94,7 @@ class CLI(UI):
     def action(self, msg, verbose = False):
         #TODO: this seems quite redundant?
         msg = unicode(msg)
+        if ctx.log:
             logging.info(msg)
         self.output(colorize(msg + '\n', 'green'))
 
@@ -151,4 +154,5 @@ class CLI(UI):
             msg = None
         if msg:
             self.output(colorize(msg + '\n', 'cyan'))
+            if ctx.log:
                 logging.info(msg)