From d9847058c2aa749036a40ffffa7ff5eb8c326f8b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bar=C4=B1=C5=9F=20Metin?= <baris@pardus.org.tr>
Date: Wed, 29 Jun 2005 11:24:49 +0000
Subject: [PATCH] =?UTF-8?q?biraz=20daha=20verify=20i=C5=9Fleri.=20sandbox/?=
 =?UTF-8?q?metadata.xml=20valid=20de=C4=9Fil.=20Hi=C3=A7=20bir=20"path"=20?=
 =?UTF-8?q?tag=C4=B1=20i=C3=A7ermiyor.=20Onu=20da=20d=C3=BCzeltece=C4=9Fiz?=
 =?UTF-8?q?.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 pisi/metadata.py           | 20 ++++++++------------
 tests/metadatatests.py     |  7 ++++++-
 tests/sandbox/metadata.xml |  1 +
 3 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/pisi/metadata.py b/pisi/metadata.py
index 2ac1ee81..0aef1ded 100644
--- a/pisi/metadata.py
+++ b/pisi/metadata.py
@@ -27,10 +27,10 @@ class SourceInfo:
         return node
 
     def verify(self):
-        ret = True
-        ret &= self.name
+        if not self.name: return False
         return True
 
+
 class PackageInfo(specfile.PackageInfo):
 
     def __init__(self, node=None):
@@ -50,9 +50,7 @@ class PackageInfo(specfile.PackageInfo):
         return node
 
     def verify(self):
-        ret = True
-        ret &= specfile.PackageInfo.verify()
-        return True
+        super(PackageInfo, self).verify()
 
 class MetaData(XmlFile):
     """Package metadata. Metadata is composed of Specfile and various
@@ -92,11 +90,9 @@ class MetaData(XmlFile):
         self.writexml(filename)
 
     def verify(self):
-        ret = True
-        ret &= hasattr(self, 'source')
-        if self.source:
-            ret &= self.source.verify()
-        ret &= self.package != None
-        if self.package:
-            ret &= self.package.verify()
+        if not hasattr(self, 'source'): return False
+        if not self.source.verify(): return False
+        
+        if not self.package: return False
+        if not self.package.verify(): return False
         return True
diff --git a/tests/metadatatests.py b/tests/metadatatests.py
index 4df64340..99356cd9 100644
--- a/tests/metadatatests.py
+++ b/tests/metadatatests.py
@@ -24,6 +24,11 @@ class MetaDataTestCase(unittest.TestCase):
     def testWrite(self):
         md = self.testRead()
         md.write(os.path.join(config.tmp_dir(),'metadata-test.xml' ))
-        
+
+    def testVerify(self):
+        md = self.testRead()
+        if not md.verify():
+            self.fail("Couldn't verify!")
+
 
 suite = unittest.makeSuite(MetaDataTestCase)
diff --git a/tests/sandbox/metadata.xml b/tests/sandbox/metadata.xml
index 1b88ae8c..5bac2067 100644
--- a/tests/sandbox/metadata.xml
+++ b/tests/sandbox/metadata.xml
@@ -4,6 +4,7 @@
 
   <Source>
   <Name>sandbox</Name>
+  <Summary>We should have something to say here.</Summary>
   <Packager>
     <Name>Meral</Name>
     <Email>meren@uludag.org.tr</Email>