From f0a78b2d0972eb9e3254836585855fe0df1c8908 Mon Sep 17 00:00:00 2001 From: Faik Uygur Date: Tue, 24 Oct 2006 22:59:22 +0000 Subject: [PATCH] * Alright. extract_install may become a longstanding operation so it is not fair to disable keyboard interrupts before that. The real critical path contains store_pisi_files which can lead to a situation that the new package's pisi files extracted and old package's are deleted from /var/lib/package but the db may not be updated. So db thinks the old version is installed but pisi files are deleted without its knowledge. And this leads to that nasty bug. Anyway, this only increases the response time without effecting the real fix. --- pisi/atomicoperations.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pisi/atomicoperations.py b/pisi/atomicoperations.py index 7e245c76..5d01bb37 100644 --- a/pisi/atomicoperations.py +++ b/pisi/atomicoperations.py @@ -106,13 +106,11 @@ class Install(AtomicOperation): self.ask_reinstall = ask_reinstall self.check_requirements() self.check_relations() - - ctx.disable_keyboard_interrupts() - self.check_reinstall() self.extract_install() - self.store_pisi_files() + ctx.disable_keyboard_interrupts() + self.store_pisi_files() self.postinstall() txn = ctx.dbenv.txn_begin()