From f750615a19473687c084e10316dc3246f5aef2b0 Mon Sep 17 00:00:00 2001
From: Faik Uygur <faik@pardus.org.tr>
Date: Mon, 28 May 2007 11:20:20 +0000
Subject: [PATCH] - even better

---
 pisi/api.py        | 14 +++++---------
 pisi/config.py     |  3 +++
 pisi/configfile.py |  1 +
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/pisi/api.py b/pisi/api.py
index ab2f2680..46ab52a3 100644
--- a/pisi/api.py
+++ b/pisi/api.py
@@ -70,12 +70,12 @@ def init(database = True, write = True,
     else:
         ctx.ui = ui
 
-    destdir = ""
-    if ctx.get_option('destdir'):
-        destdir = ctx.get_option('destdir')
+    # FIXME: something is wrong here... see __init__.py also. Why do we import pisi.api in __init__.py
+    import pisi.config
+    ctx.config = pisi.config.Config(options)
 
-    if os.access('%s/var/log' % destdir, os.W_OK):
-        handler = logging.handlers.RotatingFileHandler('%s/var/log/pisi.log' % destdir)
+    if os.access('%s/var/log' % ctx.config.log_dir(), os.W_OK):
+        handler = logging.handlers.RotatingFileHandler('%s/var/log/pisi.log' % ctx.config.log_dir())
         #handler.setLevel(logging.DEBUG)
         formatter = logging.Formatter('%(asctime)-12s: %(levelname)-8s %(message)s')
         handler.setFormatter(formatter)
@@ -93,10 +93,6 @@ def init(database = True, write = True,
     if stderr:
         ctx.stderr = stderr
 
-    # FIXME: something is wrong here... see __init__.py also. Why do we import pisi.api in __init__.py
-    import pisi.config
-    ctx.config = pisi.config.Config(options)
-
     if signal_handling:
         ctx.sig = pisi.signalhandler.SignalHandler()
 
diff --git a/pisi/config.py b/pisi/config.py
index 93f9f061..e21a53d7 100644
--- a/pisi/config.py
+++ b/pisi/config.py
@@ -86,6 +86,9 @@ class Config(object):
         pisi.util.check_dir(subdir)
         return subdir
 
+    def log_dir(self):
+        return self.subdir(self.values.dirs.log_dir)
+
     def lib_dir(self):
         return self.subdir(self.values.dirs.lib_dir)
 
diff --git a/pisi/configfile.py b/pisi/configfile.py
index 6f885af1..86fa94a3 100644
--- a/pisi/configfile.py
+++ b/pisi/configfile.py
@@ -86,6 +86,7 @@ class BuildDefaults:
 class DirectoriesDefaults:
     "Default values for [directories] section"
     lib_dir = "/var/lib/pisi"
+    log_dir = "/var/log/pisi"
     db_dir = "/var/db/pisi"
     archives_dir = "/var/cache/pisi/archives"
     packages_dir = "/var/cache/pisi/packages"