Merge pull request #9797 from 4fury-c3440d8/no

claws-mail rebuild.
This commit is contained in:
Rmys
2021-10-21 18:25:54 +03:00
committed by GitHub
4 changed files with 127 additions and 2 deletions
@@ -0,0 +1,46 @@
From 9c2585c58b49815a0eab8d683f0a94f75cbbe64e Mon Sep 17 00:00:00 2001
From: paul <paul@claws-mail.org>
Date: Mon, 12 Jul 2021 10:08:33 +0100
Subject: [PATCH] move OAuth2 to last place in auto auth selection
IMAP: when using 'automatic' auth type, if the server offers LOGIN, GSSAPI or plaintext in addition to OAUTH2, yet OAUTH2 is unconfigured, authentication will fail. This broke previously working config
---
src/imap.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/imap.c b/src/imap.c
index c486c471a..b72ceea76 100644
--- a/src/imap.c
+++ b/src/imap.c
@@ -951,14 +951,14 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
ok = imap_cmd_login(session, user, pass, "SCRAM-SHA-1");
if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "PLAIN"))
ok = imap_cmd_login(session, user, pass, "PLAIN");
- if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "XOAUTH2"))
- ok = imap_cmd_login(session, user, pass, "XOAUTH2");
if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "LOGIN"))
ok = imap_cmd_login(session, user, pass, "LOGIN");
if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "GSSAPI"))
ok = imap_cmd_login(session, user, pass, "GSSAPI");
if (ok == MAILIMAP_ERROR_LOGIN) /* we always try plaintext login before giving up */
ok = imap_cmd_login(session, user, pass, "plaintext");
+ if (ok == MAILIMAP_ERROR_LOGIN && imap_has_capability(session, "XOAUTH2"))
+ ok = imap_cmd_login(session, user, pass, "XOAUTH2");
}
if (ok == MAILIMAP_NO_ERROR)
@@ -994,6 +994,11 @@ static gint imap_auth(IMAPSession *session, const gchar *user, const gchar *pass
"LOGIN SASL plugin is installed.");
}
+ if (type == IMAP_AUTH_OAUTH2) {
+ ext_info = _("\n\nOAuth2 error. Check and correct your OAuth2 "
+ "account preferences.");
+ }
+
if (time(NULL) - last_login_err > 10) {
if (!prefs_common.no_recv_err_panel) {
alertpanel_error_log(_("Connection to %s failed: "
--
2.25.1
+10 -2
View File
@@ -38,12 +38,13 @@
<Dependency>libsocket-devel</Dependency>
<Dependency>openldap-server</Dependency>
<Dependency>libarchive-devel</Dependency>
<Dependency>gumbo-parser-devel</Dependency>
<Dependency>NetworkManager-devel</Dependency>
<Dependency>python3-pygobject3-devel</Dependency>
<Dependency>startup-notification-devel</Dependency>
</BuildDependencies>
<Patches>
<!-- <Patch level="1">missing.patch</Patch> -->
<Patch level="1">move_OAuth2_to_last_place_in_auto_auth_selection.patch</Patch>
</Patches>
</Source>
@@ -63,12 +64,14 @@
<Dependency>libSM</Dependency>
<Dependency>pango</Dependency>
<Dependency>gnutls</Dependency>
<Dependency>libgcc</Dependency>
<Dependency>libICE</Dependency>
<Dependency>nettle</Dependency>
<Dependency>libical</Dependency>
<Dependency>librsvg</Dependency>
<Dependency>openssl</Dependency>
<Dependency>python3</Dependency>
<Dependency>freetype</Dependency>
<Dependency>compface</Dependency>
<Dependency>enchant2</Dependency>
<Dependency>harfbuzz</Dependency>
@@ -78,7 +81,9 @@
<Dependency>libnotify</Dependency>
<Dependency>cyrus-sasl</Dependency>
<Dependency>gdk-pixbuf</Dependency>
<Dependency>fontconfig</Dependency>
<Dependency>libarchive</Dependency>
<Dependency>gumbo-parser</Dependency>
<Dependency>libgpg-error</Dependency>
<Dependency>openldap-client</Dependency>
<Dependency>startup-notification</Dependency>
@@ -97,6 +102,9 @@
<Name>claws-mail-devel</Name>
<RuntimeDependencies>
<Dependency release="current">claws-mail</Dependency>
<Dependency>gtk3-devel</Dependency>
<Dependency>glib2-devel</Dependency>
<Dependency>enchant2-devel</Dependency>
</RuntimeDependencies>
<Files>
<Path fileType="header">/usr/include</Path>
@@ -106,7 +114,7 @@
<History>
<Update release="1">
<Date>2021-10-13</Date>
<Date>2021-10-20</Date>
<Version>4.0.0</Version>
<Comment>First build.</Comment>
<Name>fury</Name>
@@ -0,0 +1,17 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-
#
# Licensed under the GNU General Public License, version 3.
# See the file https://www.gnu.org/licenses/gpl-3.0.txt
from pisi.actionsapi import shelltools, autotools, get
def setup():
shelltools.system("NOCONFIGURE=1 ./autogen.sh")
autotools.configure("--disable-static")
def build():
autotools.make()
def install():
autotools.rawInstall("DESTDIR=%s" % get.installDIR())
@@ -0,0 +1,54 @@
<?xml version="1.0" ?>
<!DOCTYPE PISI SYSTEM "https://pisilinux.org/projeler/pisi/pisi-spec.dtd">
<PISI>
<Source>
<Name>gumbo-parser</Name>
<Homepage>https://github.com/google/gumbo-parser</Homepage>
<Packager>
<Name>pisilinux community</Name>
<Email>admins@pisilinux.org</Email>
</Packager>
<License>Apache-2</License>
<IsA>library</IsA>
<PartOf>programming.library</PartOf>
<Summary>An HTML5 parsing library in pure C99.</Summary>
<Description>Gumbo is an implementation of the HTML5 parsing algorithm implemented as a pure C99 library with no outside dependencies.</Description>
<Archive sha1sum="55dd0b76094eeda1e93fe9fd0939b86936bbdca6" type="targz">
https://github.com/google/gumbo-parser/archive/refs/tags/v0.10.1.tar.gz
</Archive>
<BuildDependencies>
<!-- <Dependency></Dependency> -->
</BuildDependencies>
</Source>
<Package>
<Name>gumbo-parser</Name>
<RuntimeDependencies>
<!-- <Dependency></Dependency> -->
</RuntimeDependencies>
<Files>
<Path fileType="library">/usr/lib</Path>
</Files>
</Package>
<Package>
<Name>gumbo-parser-devel</Name>
<RuntimeDependencies>
<Dependency release="current">gumbo-parser</Dependency>
</RuntimeDependencies>
<Files>
<Path fileType="header">/usr/include</Path>
<Path fileType="library">/usr/lib/pkgconfig</Path>
</Files>
</Package>
<History>
<Update release="1">
<Date>2021-10-20</Date>
<Version>0.10.1</Version>
<Comment>First build.</Comment>
<Name>pisilinux community</Name>
<Email>admins@pisilinux.org</Email>
</Update>
</History>
</PISI>