* new translations, cosmetic changes

* specfile: don't bail if there is no comment, name, email

pisi-cli

@@ -30,13 +30,13 @@ def handle_exception(exception, value, tb):
     ui = pisi.cli.CLI() # make a temporary UI
     show_traceback = False
     if exception == exceptions.KeyboardInterrupt:
-        ui.error(_("\nKeyboardInterrupt: Exiting...\n"))
+        ui.error(_("KeyboardInterrupt: Exiting...\n"))
         sys.exit(1)
     elif exception == XmlError:
         ui.error(unicode(value))
         sys.exit(1)
     elif isinstance(value, pisi.Error):
-        ui.error(_("\nFatal Error. Program Terminated."))
+        ui.error(_("Fatal Error. Program Terminated."))
         show_traceback = ctx.config.get_option('debug')
     elif isinstance(value, pisi.Exception):
         show_traceback = True
@@ -47,7 +47,7 @@ Please file a bug report. (http://bugs.uludag.org.tr)"""))
         # For any other exception (possibly Python exceptions) show
         # the traceback!
         show_traceback = ctx.config.get_option('debug')
-        ui.error(_("\nSystem Error. Program Terminated."))
+        ui.error(_("System Error. Program Terminated."))
 
     ui.error("%s: %s\n" % (exception, value))
 

pisi/actionsapi/pisitoolsfunctions.py

@@ -69,7 +69,7 @@ def lib_insinto(sourceFile, destinationDirectory, permission = 0644):
     '''inserts a library fileinto destinationDirectory with given permission'''
 
     if not sourceFile or not destinationDirectory:
-        raise ArgumentError(_(' Insufficient arguments.'))
+        raise ArgumentError(_('Insufficient arguments.'))
 
     if not can_access_directory(destinationDirectory):
         makedirs(destinationDirectory)

pisi/actionsapi/shelltools.py

@@ -44,7 +44,7 @@ def makedirs(destinationDirectory):
         if not os.access(destinationDirectory, os.F_OK):
             os.makedirs(destinationDirectory)
     except OSError:
-        error(_('Cannot create directory %s' % destinationDirectory))
+        error(_('Cannot create directory %s') % destinationDirectory)
 
 def echo(destionationFile, content):
     try:
@@ -61,10 +61,10 @@ def chmod(sourceFile, mode = 0755):
             try:
                 os.chmod(file, mode)
             except OSError:
-                ctx.ui.error(_(' ActionsAPI [chmod]: Operation not permitted: %s (mode: %s)') \
+                ctx.ui.error(_('ActionsAPI [chmod]: Operation not permitted: %s (mode: %s)') \
                                                                 % (file, mode))
         else:
-            ctx.ui.error(_(' ActionsAPI [chmod]: File %s doesn\'t exists.') % (file))
+            ctx.ui.error(_('ActionsAPI [chmod]: File %s doesn\'t exists.') % (file))
 
 def chown(sourceFile, uid = "root", gid = "root"):
     '''change the owner and group id of sourceFile to uid and gid'''
@@ -72,17 +72,17 @@ def chown(sourceFile, uid = "root", gid = "root"):
         try:
             os.chown(sourceFile, pwd.getpwnam(uid)[2], grp.getgrnam(gid)[2])
         except OSError:
-            ctx.ui.error(_(' ActionsAPI [chown]: Operation not permitted: %s (uid: %s, gid: %s)') \
+            ctx.ui.error(_('ActionsAPI [chown]: Operation not permitted: %s (uid: %s, gid: %s)') \
                                                  % (sourceFile, uid, gid))
     else:
-        ctx.ui.error(_(' ActionsAPI [chown]: File %s doesn\'t exists.') % sourceFile)
+        ctx.ui.error(_('ActionsAPI [chown]: File %s doesn\'t exists.') % sourceFile)
 
 def sym(sourceFile, destinationFile):
     '''creates symbolic link'''
     try:
         os.symlink(sourceFile, destinationFile)
     except OSError:
-        ctx.ui.error(_(' ActionsAPI [sym]: Permission denied: %s to %s') % (file, destinationFile))
+        ctx.ui.error(_('ActionsAPI [sym]: Permission denied: %s to %s') % (file, destinationFile))
 
 def unlink(sourceFile):
     '''remove the file path'''
@@ -90,11 +90,11 @@ def unlink(sourceFile):
         try:
             os.unlink(sourceFile)
         except OSError:
-            ctx.ui.error(_(' ActionsAPI [unlink]: Permission denied: %s.') % (sourceFile))
+            ctx.ui.error(_('ActionsAPI [unlink]: Permission denied: %s.') % (sourceFile))
     elif isDirectory(sourceFile):
         pass
     else:
-        ctx.ui.error(_(' ActionsAPI [unlink]: File %s doesn\'t exists.') % (sourceFile))
+        ctx.ui.error(_('ActionsAPI [unlink]: File %s doesn\'t exists.') % (sourceFile))
 
 def unlinkDir(sourceDirectory):
     '''delete an entire directory tree'''
@@ -102,11 +102,11 @@ def unlinkDir(sourceDirectory):
         try:
             shutil.rmtree(sourceDirectory)
         except OSError:
-            error(_(' ActionsAPI [unlinkDir]: Operation not permitted: %s') % (sourceDirectory))
+            error(_('ActionsAPI [unlinkDir]: Operation not permitted: %s') % (sourceDirectory))
     elif isFile(sourceDirectory):
         pass                                
     else:
-        error(_(' ActionsAPI [unlinkDir]: Directory %s doesn\'t exists.') % (sourceDirectory))
+        error(_('ActionsAPI [unlinkDir]: Directory %s doesn\'t exists.') % (sourceDirectory))
 
 def move(sourceFile, destinationFile):
     '''recursively move a sourceFile or directory to destinationFile'''
@@ -115,9 +115,9 @@ def move(sourceFile, destinationFile):
             try:
                 shutil.move(file, destinationFile)
             except OSError:
-                error(_(' ActionsAPI [move]: Permission denied: %s to %s') % (file, destinationFile))
+                error(_('ActionsAPI [move]: Permission denied: %s to %s') % (file, destinationFile))
         else:
-            error(_(' ActionsAPI [move]: File %s doesn\'t exists.') % (file))
+            error(_('ActionsAPI [move]: File %s doesn\'t exists.') % (file))
 
 def copy(sourceFile, destinationFile):
     '''recursively copy a sourceFile or directory to destinationFile'''
@@ -138,9 +138,9 @@ def copytree(source, destination, sym = False):
         try:
             shutil.copytree(source, destination, sym)
         except OSError:
-            error(_(' ActionsAPI [copytree]: Permission denied: %s to %s') % (source, destination))
+            error(_('ActionsAPI [copytree]: Permission denied: %s to %s') % (source, destination))
     else:
-        error(_(' ActionsAPI [copytree]: Directory %s doesn\'t exists.') % (source))
+        error(_('ActionsAPI [copytree]: Directory %s doesn\'t exists.') % (source))
 
 def touch(sourceFile):
     '''changes the access time of the 'sourceFile', or creates it if it is not exist'''
@@ -152,7 +152,7 @@ def touch(sourceFile):
             f = open(sourceFile, 'w')
             f.close()
         except IOError:
-            error(_(' ActionsAPI [touch]: Permission denied: %s') % (sourceFile))
+            error(_('ActionsAPI [touch]: Permission denied: %s') % (sourceFile))
 
 def cd(directoryName = ''):
     '''change directory'''

pisi/specfile.py

@@ -150,11 +150,14 @@ class UpdateInfo:
         node.setAttribute("release", self.release)
         xml.addTextNodeUnder(node, "Date", self.date)
         xml.addTextNodeUnder(node, "Version", self.version)
-        xml.addTextNodeUnder(node, "Comment", self.comment)
-        xml.addTextNodeUnder(node, "Name", self.name)
-        xml.addTextNodeUnder(node, "Email", self.email)
+        if self.comment:
+            xml.addTextNodeUnder(node, "Comment", self.comment)
+        if self.name:
+            xml.addTextNodeUnder(node, "Name", self.name)
+        if self.email:
+            xml.addTextNodeUnder(node, "Email", self.email)
         if self.type:
-                node.setAttribute("type", self.type)
+            node.setAttribute("type", self.type)
         return node
 
     def has_errors(self):